chore: fix library source lint#487
Merged
Merged
Conversation
… warn, no-unused-expressions allow options)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the pre-existing
yarn lintdebt in the React library source (separate from the docs-examples cleanup already merged on main).eslint-plugin-react-hooks@7, which promoted the react-compiler rules intorecommended: the newly-introduced ones (react-hooks/refs,set-state-in-effect,static-components) are set towarnso they don't fail CI on working components; classicrules-of-hooksstays an error.@typescript-eslint/no-unused-expressionsconfigured withallowShortCircuit/allowTernaryto match the codebase's side-effect idioms.replace(/g)→replaceAll, intentional reflow reads renamed to_reflow, andCTableItemvalue typing (unknowndata + typed_cellProps+as ReactNodeat render).yarn lintnow reports 0 errors in the library source. Lib build + unit tests green.